Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Fajr Wake Up screen text alignment to two lines #1564

Open
wants to merge 1 commit into
base: release-1.21
Choose a base branch
from
Open

fix: update Fajr Wake Up screen text alignment to two lines #1564

wants to merge 1 commit into from

Conversation

YassinNouh21
Copy link
Contributor

@YassinNouh21 YassinNouh21 commented Jan 27, 2025 •
edited
Loading

📝 Summary

This PR fixes #1490

Description

Fix text alignment issue in Fajr Wake Up screen by splitting content into two lines for better readability and visual presentation.

Tests

🧪 Use case 1

💬 Description:

  1. Open the app
  2. Navigate to Fajr Wake Up screen

📷 Screenshots or GIFs (if applicable):

image

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

@YassinNouh21 YassinNouh21 linked an issue Jan 28, 2025 that may be closed by this pull request
Put this text on 2 lines #1490
Open
@YassinNouh21 YassinNouh21 self-assigned this Jan 28, 2025
ghassenbenzahra123
ghassenbenzahra123 reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ghassenbenzahra123 ghassenbenzahra123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

on large screens it still appears on 1 line @YassinNouh21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghassenbenzahra123 ghassenbenzahra123 ghassenbenzahra123 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@YassinNouh21 YassinNouh21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put this text on 2 lines
2 participants
@YassinNouh21 @ghassenbenzahra123